Attention is currently required from: Paul Menzel, Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57634 )
Change subject: mb/google/brya: Add WWAN poweroff sequence ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57634/comment/4588264d_562b32a7 PS2, Line 7: power off
The noun should be spelled without a space: poweroff
Done
https://review.coreboot.org/c/coreboot/+/57634/comment/329c7630_477f9eae PS2, Line 12: meet
meeting
Done
File src/mainboard/google/brya/variants/brya0/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/57634/comment/73c6edae_3056c2e4 PS2, Line 11: T1_OFF
Please add the unit to the variable name like `T1_OFF_MS`.
Done
-
EricR Lai (Code Review)