Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Arthur Heymans.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74256 )
Change subject: {commonlib, soc/intel/cmn/cse}: Store CSE firmware version into CBMEM
......................................................................
Patch Set 17: Code-Review+2
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74256/comment/5429f4af_23a50a66
PS16, Line 1250: if (CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE) && !s3wake) {
: timestamp_add_now(TS_CSE_FW_SYNC_START);
: cse_fw_sync();
: timestamp_add_now(TS_CSE_FW_SYNC_END);
:
: if (CONFIG(SOC_INTEL_STORE_CSE_FPT_PARTITION_VERSION))
: store_cse_rw_fw_version();
: }
: }
The codeflow is quite confusing... […]
Otherway this can be done by just checking the CSE Lite version in the CSE RW blob's metadata. In this scenario, coreboot need not interact with CSE and checking CSE blob only once is required. We plan to add the change later one this patchtrain get merged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74256
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I923049d2f1f589f87e1a29e1ac94af7f5fccc2c8
Gerrit-Change-Number: 74256
Gerrit-PatchSet: 17
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 18 Apr 2023 18:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment