Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44000 )
Change subject: soc/intel/jasperlake: Add IGD Device ID ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@7 PS2, Line 7: new
don't need this word here, its enough to say Add IGD device id
Done
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: new
same
Done
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@9 PS2, Line 9: jasperlake
Jasperlake
Done
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@10 PS2, Line 10: Reference is taken from jasperlake EDS volume 1 chapter 13.3
possible to give doc number is enough than chapter
Done
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@12 PS2, Line 12: BRANCH=None : BUG=None
don't need
Done
https://review.coreboot.org/c/coreboot/+/44000/2//COMMIT_MSG@14 PS2, Line 14: jasperlake
Jasperlake
Done
-
Krishna P Bhat D (Code Review)