Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47989 )
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
src/soc/intel/tigerlake: Add SPI DMI Destination ID
This change adds the SPI-DMI Destination ID for tigerlake soc. This is needed for enabling support for extended BIOS region.
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: I0b6a8af0c1e79fa668ef2f84b93f3bbece59eb6a --- M src/soc/intel/tigerlake/include/soc/pcr_ids.h 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/47989/1
diff --git a/src/soc/intel/tigerlake/include/soc/pcr_ids.h b/src/soc/intel/tigerlake/include/soc/pcr_ids.h index 7388593..319558a 100644 --- a/src/soc/intel/tigerlake/include/soc/pcr_ids.h +++ b/src/soc/intel/tigerlake/include/soc/pcr_ids.h @@ -31,4 +31,9 @@ #define PID_ESPI 0xc7 #define PID_SERIALIO 0xcb
+/* + * SPI - DMI Destination ID + */ +#define SPI_DMI_DESTINATION_ID 0x23a8 + #endif
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47989 )
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47989
to look at the new patch set (#5).
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
src/soc/intel/tigerlake: Add SPI DMI Destination ID
This change adds the SPI-DMI Destination ID for tigerlake soc. This is needed for enabling support for extended BIOS region. Also, implements a SOC helper function soc_get_spi_dmi_destination_id() which returns SPI-DMI Destination id.
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: I0b6a8af0c1e79fa668ef2f84b93f3bbece59eb6a --- M src/soc/intel/tigerlake/include/soc/pcr_ids.h M src/soc/intel/tigerlake/spi.c 2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/47989/5
Hello build bot (Jenkins), Furquan Shaikh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47989
to look at the new patch set (#6).
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
src/soc/intel/tigerlake: Add SPI DMI Destination ID
This change adds the SPI-DMI Destination ID for tigerlake soc. This is needed for enabling support for extended BIOS region. Also, implements a SOC helper function soc_get_spi_dmi_destination_id() which returns SPI-DMI Destination id.
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: I0b6a8af0c1e79fa668ef2f84b93f3bbece59eb6a --- M src/soc/intel/tigerlake/include/soc/pcr_ids.h M src/soc/intel/tigerlake/spi.c 2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/47989/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47989 )
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
Patch Set 7: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47989 )
Change subject: src/soc/intel/tigerlake: Add SPI DMI Destination ID ......................................................................
src/soc/intel/tigerlake: Add SPI DMI Destination ID
This change adds the SPI-DMI Destination ID for tigerlake soc. This is needed for enabling support for extended BIOS region. Also, implements a SOC helper function soc_get_spi_dmi_destination_id() which returns SPI-DMI Destination id.
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: I0b6a8af0c1e79fa668ef2f84b93f3bbece59eb6a Reviewed-on: https://review.coreboot.org/c/coreboot/+/47989 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/tigerlake/include/soc/pcr_ids.h M src/soc/intel/tigerlake/spi.c 2 files changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/include/soc/pcr_ids.h b/src/soc/intel/tigerlake/include/soc/pcr_ids.h index 7388593..319558a 100644 --- a/src/soc/intel/tigerlake/include/soc/pcr_ids.h +++ b/src/soc/intel/tigerlake/include/soc/pcr_ids.h @@ -31,4 +31,9 @@ #define PID_ESPI 0xc7 #define PID_SERIALIO 0xcb
+/* + * SPI - DMI Destination ID + */ +#define SPI_DMI_DESTINATION_ID 0x23a8 + #endif diff --git a/src/soc/intel/tigerlake/spi.c b/src/soc/intel/tigerlake/spi.c index 63d9d80..ef86fea 100644 --- a/src/soc/intel/tigerlake/spi.c +++ b/src/soc/intel/tigerlake/spi.c @@ -7,7 +7,9 @@ */
#include <intelblocks/spi.h> +#include <intelblocks/fast_spi.h> #include <soc/pci_devs.h> +#include <soc/pcr_ids.h>
int spi_soc_devfn_to_bus(unsigned int devfn) { @@ -23,3 +25,8 @@ } return -1; } + +uint32_t soc_get_spi_dmi_destination_id(void) +{ + return SPI_DMI_DESTINATION_ID; +}
-
Furquan Shaikh (Code Review) -
Srinidhi N Kaushik (Code Review)