Attention is currently required from: EricR Lai, Karthik Ramasubramanian. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52363 )
Change subject: mb/google/octopus/var/fleex: Add ssfc codec cs42l42 support ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/c/coreboot/+/52363/comment/9647b720_281df1e2 PS7, Line 18: PAD_CFG_GPI_APIC_IOS(GPIO_137, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD), Just confirm the interrupt type of this codec is the same with da7219?
https://review.coreboot.org/c/coreboot/+/52363/comment/58da01a9_efd7b91f PS7, Line 21: /* GPIO_144 -- Codec reset pin. */ : PAD_CFG_GPO(GPIO_144, 1, PWROK),
@Karthik, is it okay? Or I need extra override by SSFC?
From HW side, if we make sure the old board is NC for this GPIO then I would be good to keep this GPIO setting the same for old and new board.
-
Marco Chen (Code Review)