Attention is currently required from: Raul Rangel, Furquan Shaikh. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54132 )
Change subject: drivers/acpi: Add device tree driver to generate thermal zone ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/acpi/thermal_zone/thermal_zone.c:
https://review.coreboot.org/c/coreboot/+/54132/comment/99890fe3_3407d1c9 PS2, Line 98: !config->passive_config.time_constant_1 : || !config->passive_config.time_constant_2 : || !config->passive_config.time_sampling_period) { : acpigen_write_name_integer("_TC1", 2); : acpigen_write_name_integer("_TC2", 5); : acpigen_write_name_integer("_TSP", SECONDS_TO_DECI_SECONDS(10)); Should there be an error instead of emitting defaults?
https://review.coreboot.org/c/coreboot/+/54132/comment/a2c2b2ac_5de7ab4f PS2, Line 114: : config->temperature_controller->ops->acpigen_write_TMP(dev); Hmm... I'm not a big fan of adding a new callback to `struct device *`... I see where the tricky part of this, how to get the right acpigen calls when emitting `_TMP`.
What do you think about just writing a `_TMP` that forwards the call to the `_TMP` of the temperature_controller device instead? e.g.
``` /* Method (_TMP, 1) { Return acpi_path(temperature_controller)._TMP(Arg0) } */ acpigen_write_method("_TMP", 0); acpigen_emit_byte(RETURN_OP); acpigen_emit_namestring(acpi_device_path_join(config->temperature_controller), "_TMP"); acpigen_emit_byte(ARG0_OP); acpigen_write_method_end(); ```
?