Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Implement readat_async - coreboot-gerrit

7 Jul 2021


      Attention is currently required from: Jason Glenesk, Marshall Dawson, Paul Menzel, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55857 )
Change subject: soc/amd/common/block/lpc/spi_dma: Implement readat_async
......................................................................
Patch Set 8:
(1 comment)
File src/soc/amd/common/block/lpc/spi_dma.c:
https://review.coreboot.org/c/coreboot/+/55857/comment/6b556f5d_96e60043 
PS5, Line 34:  * can always move the number to a Kconfig if necessary. */
...
Please use one of the recommended multi-line comment styles [1]. […]
lol, oops/
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55857
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0be555956581fd82bbe1482d8afa8828c61aaa00
Gerrit-Change-Number: 55857
Gerrit-PatchSet: 8
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 07 Jul 2021 20:24:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment