Attention is currently required from: Raul Rangel, Martin Roth, Julius Werner, Rob Barnes.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58982 )
Change subject: src/lib/prog_loaders: Add preload_ramstage
......................................................................
Patch Set 3:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58982/comment/d13d9a07_0f6fcfb3
PS3, Line 1219: $(CONFIG_CBFS_PREFIX)/ramstage-align := 64
`ramstage-align` is not set in that case. […]
Minimum alignment for file data is unspecified.
CBFS file headers are aligned to 64byte boundaries, and are typically sized in multiples of 4. File data follows headers so there's currently an implicit and unofficial file data alignment to 4 bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe12de806449da25bc0033b02fcb97c3384eddc1
Gerrit-Change-Number: 58982
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 16:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment