Change in coreboot[master]: intel/braswell: Drop use of <device/early_smbus.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38046 )

Change subject: intel/braswell: Drop use of <device/early_smbus.h>
......................................................................

intel/braswell: Drop use of <device/early_smbus.h>

Change-Id: Id3fa0745e90d8bb99965eceec0ac129fe0ff7446
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/braswell/smbus.c
1 file changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38046/1

diff --git a/src/soc/intel/braswell/smbus.c b/src/soc/intel/braswell/smbus.c
index 1dfd4c7..abf2fea 100644
--- a/src/soc/intel/braswell/smbus.c
+++ b/src/soc/intel/braswell/smbus.c
@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */

-#include <device/early_smbus.h>
 #include <soc/iomap.h>
 #include <soc/pci_devs.h>
 #include <device/pci_def.h>
@@ -24,16 +23,6 @@
 #include <soc/smbus.h>
 #include <southbridge/intel/common/smbus.h>

-u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset)
-{
-	return do_smbus_read_byte(SMBUS_BASE_ADDRESS, addr, offset);
-}
-
-u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value)
-{
-	return do_smbus_write_byte(SMBUS_BASE_ADDRESS, addr, offset, value);
-}
-
 int smbus_i2c_block_write(u8 addr, u8 bytes, u8 *buf)
 {
 #ifdef __SIMPLE_DEVICE__

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38046 )

Change subject: intel/braswell: Drop use of <device/early_smbus.h>
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38046 )

Change subject: intel/braswell: Drop use of <device/early_smbus.h>
......................................................................

Patch Set 1: Code-Review+1

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38046 )

Change subject: intel/braswell: Drop use of <device/early_smbus.h>
......................................................................

intel/braswell: Drop use of <device/early_smbus.h>

Change-Id: Id3fa0745e90d8bb99965eceec0ac129fe0ff7446
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38046
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Frans Hendriks 
---
M src/soc/intel/braswell/smbus.c
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Frans Hendriks: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/braswell/smbus.c b/src/soc/intel/braswell/smbus.c
index 1dfd4c7..abf2fea 100644
--- a/src/soc/intel/braswell/smbus.c
+++ b/src/soc/intel/braswell/smbus.c
@@ -15,7 +15,6 @@
  * GNU General Public License for more details.
  */

-#include <device/early_smbus.h>
 #include <soc/iomap.h>
 #include <soc/pci_devs.h>
 #include <device/pci_def.h>
@@ -24,16 +23,6 @@
 #include <soc/smbus.h>
 #include <southbridge/intel/common/smbus.h>

-u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset)
-{
-	return do_smbus_read_byte(SMBUS_BASE_ADDRESS, addr, offset);
-}
-
-u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value)
-{
-	return do_smbus_write_byte(SMBUS_BASE_ADDRESS, addr, offset, value);
-}
-
 int smbus_i2c_block_write(u8 addr, u8 bytes, u8 *buf)
 {
 #ifdef __SIMPLE_DEVICE__