Attention is currently required from: Angel Pons, Arthur Heymans, Keith Hui.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 )
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd() ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/asus/p8x7x-series/early_init.c:
https://review.coreboot.org/c/coreboot/+/61540/comment/40fffb80_8e95de67 PS3, Line 5: void __weak
Future proofing as explained in the commit message. Not all boards have 4 RAM slots. […]
Sorry, probably didn't read the commit message ._.
Still, weak functions are a bit frowned upon. And adding the `__weak` later in case one needs it really isn't much trouble. Until then it can only cause problems (pick your usual trouble with weak functions; somebody forgets to override it, people loose track reading the code, ...).
Also, even if there will be different implementations in the future, a weak func- tion isn't the only solution. Making it weak now, unnecessarily sets a precedent. IOW, do you expect to discuss now what the best solution would be?
-
Nico Huber (Code Review)