Attention is currently required from: Cliff Huang, Elyes Haouas, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )
Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi_apic.c:
https://review.coreboot.org/c/coreboot/+/82642/comment/70c501c1_8dfc8c34?usp... :
PS1, Line 130: ACPI_HAVE_PCAT_8259
shouldn't this to be ACPI_PCAT_COMPAT, or I'm confused ? […]
i'm not sure what you mean here. in this patch i removed the sort-of duplicate ACPI_HAVE_PCAT_8259 Kconfig and used ACPI_NO_PCAT_8259 instead; this patch shouldn't change any behavior. or do you mean the rest of this function? can't say that i fully understood what this case does exactly; the data structure here is this one https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html?high... so there's no ACPI_PCAT_COMPAT bit in there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82642?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2
Gerrit-Change-Number: 82642
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 24 May 2024 14:42:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr