Change in ...coreboot[master]: mb/google/octopus: Add a missing IOstandby setting for gpio_178
Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32247
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
mb/google/octopus: Add a missing IOstandby setting for gpio_178
Other varant boards of octopus added IOstandby setting for gpio_178, excepted meep/bloog. Add a missing IOstandby setting of gpio_178 for meep/bloog.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/1
diff --git a/src/mainboard/google/octopus/variants/bloog/gpio.c b/src/mainboard/google/octopus/variants/bloog/gpio.c index 2b29cba..0c19570 100644 --- a/src/mainboard/google/octopus/variants/bloog/gpio.c +++ b/src/mainboard/google/octopus/variants/bloog/gpio.c @@ -44,7 +44,7 @@ DISPUPD),
/* EN_PP3300_WLAN_L */ - PAD_CFG_GPO(GPIO_178, 0, DEEP), + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), };
const struct pad_config *variant_override_gpio_table(size_t *num) diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c index 001a488..17157d6 100644 --- a/src/mainboard/google/octopus/variants/meep/gpio.c +++ b/src/mainboard/google/octopus/variants/meep/gpio.c @@ -26,7 +26,7 @@ DISPUPD),
/* EN_PP3300_WLAN_L */ - PAD_CFG_GPO(GPIO_178, 0, DEEP), + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), };
const struct pad_config *variant_override_gpio_table(size_t *num)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32247/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/gpio.c:
https://review.coreboot.org/#/c/32247/1/src/mainboard/google/octopus/variant... PS1, Line 47: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters
https://review.coreboot.org/#/c/32247/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/meep/gpio.c:
https://review.coreboot.org/#/c/32247/1/src/mainboard/google/octopus/variant... PS1, Line 29: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), line over 80 characters
Hello Justin TerAvest,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#2).
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
mb/google/octopus: Add a missing IOstandby setting for gpio_178
Other varant boards of octopus added IOstandby setting for gpio_178, excepted meep/bloog. Add a missing IOstandby setting of gpio_178 for meep/bloog.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32247/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/gpio.c:
https://review.coreboot.org/#/c/32247/2/src/mainboard/google/octopus/variant... PS2, Line 47: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, trailing whitespace
Hello Justin TerAvest, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#3).
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
mb/google/octopus: Add a missing IOstandby setting for gpio_178
Other varant boards of octopus added IOstandby setting for gpio_178, excepted meep/bloog. Add a missing IOstandby setting of gpio_178 for meep/bloog.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/3
Chen Wisley has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Abandoned
Chen Wisley has restored this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Restored
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Add a missing IOstandby setting for gpio_178 ......................................................................
Patch Set 3:
Let's just change this:
https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/octo...
to
PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN_L */
so that the default configuration is active low and IOStandby for EN_PP3300_WLAN_L and then remove GPIO_178 completely from the default_override_table for following variants: bloog bobba fleex meep phaser
Ampton has another issue, it has the polarity incorrect. Let me file a separate bug for that, but let's make the above change for rest of the boards.
yorp and bip have active high enable so let's leave their configuration as is.
Hello Kane Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#4).
Change subject: mb/google/octopus: Set default config is low for gpio_178 ......................................................................
mb/google/octopus: Set default config is low for gpio_178
Set default config is low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For casta/ampton, needs other CL to override setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default config is low for gpio_178 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32247/4/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32247/4/src/mainboard/google/octopus/variant... PS4, Line 252: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default config is low for gpio_178 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32247/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32247/4//COMMIT_MSG@7 PS4, Line 7: mb/google/octopus: Set default config is low for gpio_178 Two verbs do not parse right here. Maybe:
Make low default config for gpio_178
Hello Kane Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#5).
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
mb/google/octopus: Set default configuration to low for gpio_178
Set default configuration to low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For casta/ampton, needs other CL to override setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32247/5/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32247/5/src/mainboard/google/octopus/variant... PS5, Line 252: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ EN_PP3300_WLAN_L
https://review.coreboot.org/#/c/32247/5/src/mainboard/google/octopus/variant... PS5, Line 252: 1 0
Hello Kane Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#6).
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
mb/google/octopus: Set default configuration to low for gpio_178
Set default configuration to low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For casta/ampton, needs other CL to override setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32247/6/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32247/6/src/mainboard/google/octopus/variant... PS6, Line 252: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN_L */ line over 80 characters
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 6: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 6:
Hi Furquan, I saw the CL:32255 to fix issue for ampton. For casta, do I need to add PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ in override table?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 6:
Patch Set 6:
Hi Furquan, I saw the CL:32255 to fix issue for ampton. For casta, do I need to add PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ in override table?
No, casta doesn't seem to be using GPIO_178 at all. Can you please update your commit message to remove mention of casta?
Hello Kane Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#7).
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
mb/google/octopus: Set default configuration to low for gpio_178
Set default configuration to low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For ampton, needs other CL to override setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/7
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 7:
Patch Set 6:
Patch Set 6:
Hi Furquan, I saw the CL:32255 to fix issue for ampton. For casta, do I need to add PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ in override table?
No, casta doesn't seem to be using GPIO_178 at all. Can you please update your commit message to remove mention of casta?
got it, thank for your explanation
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32247/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32247/7//COMMIT_MSG@12 PS7, Line 12: CL Please reference the Change-Id and commit message summary.
Hello Kane Chen, Justin TerAvest, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32247
to look at the new patch set (#8).
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
mb/google/octopus: Set default configuration to low for gpio_178
Set default configuration to low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For ampton, Change-Id I64a67f73564188ad0548a1a770169ef2bca47453 ( mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.) modified the pin setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/32247/8
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 8: Code-Review+1
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 8: Code-Review+2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 8:
Hi Furquan,
Could you help to merge it?
Thanks
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
mb/google/octopus: Set default configuration to low for gpio_178
Set default configuration to low for gpio_178, and can remove the override setting for bobba/bloog/fleex/meep/phaser.
For ampton, Change-Id I64a67f73564188ad0548a1a770169ef2bca47453 ( mb/google/ampton: Fix polarity of EN_PP3300_WLAN_L signal.) modified the pin setting.
TEST=verified that boot into OS on meep board. suspend/resume, reboot, and no failure found.
Change-Id: I7668ff4817edfca5c6cea63db779fcea21c7af92 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32247 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/baseboard/gpio.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c 6 files changed, 2 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Justin TerAvest: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/baseboard/gpio.c b/src/mainboard/google/octopus/variants/baseboard/gpio.c index 3305c02..febf779 100644 --- a/src/mainboard/google/octopus/variants/baseboard/gpio.c +++ b/src/mainboard/google/octopus/variants/baseboard/gpio.c @@ -249,7 +249,8 @@ /* SCC COMMUNITY GPIOS */ PAD_NC(GPIO_176, UP_20K), /* SMB_ALERTB -- unused */ PAD_NC(GPIO_177, UP_20K), /* SMB_CLK -- unused */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* EN_PP3300_WLAN */ + PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_WLAN_L */ + PAD_NC(GPIO_179, NONE), /* SDCARD_CLK -- unused */ PAD_NC(GPIO_180, NONE), /* SDCARD_CMD -- unused */ PAD_NC(GPIO_181, UP_20K), /* SDCARD_D0 -- unused */ diff --git a/src/mainboard/google/octopus/variants/bloog/gpio.c b/src/mainboard/google/octopus/variants/bloog/gpio.c index 2b29cba..cf3bc4c 100644 --- a/src/mainboard/google/octopus/variants/bloog/gpio.c +++ b/src/mainboard/google/octopus/variants/bloog/gpio.c @@ -42,9 +42,6 @@ /* EN_PP3300_TOUCHSCREEN */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), - - /* EN_PP3300_WLAN_L */ - PAD_CFG_GPO(GPIO_178, 0, DEEP), };
const struct pad_config *variant_override_gpio_table(size_t *num) diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c index e11f6cf..6bfe54a 100644 --- a/src/mainboard/google/octopus/variants/bobba/gpio.c +++ b/src/mainboard/google/octopus/variants/bobba/gpio.c @@ -26,9 +26,6 @@ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
- /* EN_PP3300_WLAN_L */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), - PAD_NC(GPIO_213, DN_20K), };
diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index 6bb78aa..89adfb8 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -41,9 +41,6 @@
PAD_NC(GPIO_161, UP_20K),
- /* EN_PP3300_WLAN_L */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), - PAD_NC(GPIO_213, DN_20K), PAD_NC(GPIO_214, DN_20K), }; diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c index 001a488..7b47bf1 100644 --- a/src/mainboard/google/octopus/variants/meep/gpio.c +++ b/src/mainboard/google/octopus/variants/meep/gpio.c @@ -24,9 +24,6 @@ /* EN_PP3300_TOUCHSCREEN */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), - - /* EN_PP3300_WLAN_L */ - PAD_CFG_GPO(GPIO_178, 0, DEEP), };
const struct pad_config *variant_override_gpio_table(size_t *num) diff --git a/src/mainboard/google/octopus/variants/phaser/gpio.c b/src/mainboard/google/octopus/variants/phaser/gpio.c index 6883ab0..076476b 100644 --- a/src/mainboard/google/octopus/variants/phaser/gpio.c +++ b/src/mainboard/google/octopus/variants/phaser/gpio.c @@ -36,9 +36,6 @@
PAD_NC(GPIO_161, DN_20K),
- /* EN_PP3300_WLAN_L */ - PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), - PAD_NC(GPIO_213, DN_20K), PAD_NC(GPIO_214, DN_20K), };
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32247 )
Change subject: mb/google/octopus: Set default configuration to low for gpio_178 ......................................................................
Patch Set 9:
Hi Furquan,
Could you help to cherry-pick it into chromium master branch?
Thanks
-
build bot (Jenkins) (Code Review) -
Chen Wisley (Code Review)
-
Furquan Shaikh (Code Review)
-
Justin TerAvest (Code Review)
-
Paul Menzel (Code Review)