Attention is currently required from: Jamie Chen, Tim Wawrzynczak.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63675 )
Change subject: soc/intel/jasperlake: CNVi: Enable fewer wakeups to reduce SoC power consumption
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63675/comment/282ed3af_e18fc1b9
PS5, Line 428: * Setting this on a system that supports S0i3 (set xtalsdqdis [Bit 22] in
: * cppmvric1 register to 0) will break CNVI timing.
The xtalsdqdis bit can be set or clear by ASL code or OS code. […]
Ack
File src/soc/intel/jasperlake/finalize.c:
https://review.coreboot.org/c/coreboot/+/63675/comment/cacba913_21b1b413
PS5, Line 63: if (config->cnvi_reduce_s0ix_pwr_usage) {
This is only for system with CNVi module to work around and keeping this enabled will not impact the […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56439a406547e2ee1e47d34be14ecc9a8df04693
Gerrit-Change-Number: 63675
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Thu, 21 Apr 2022 16:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment