Attention is currently required from: Paul Menzel, Jacob Garber.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55075 )
Change subject: include: always unsigned long for size_t
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yeah, it looks like GCC is using its own definition of size_t when warning about the format modifier […]
Yeah, now I understand what that stuff actually does. In fact, maybe we should be using __PTRDIFF_TYPE__ and __UINTPTR_TYPE__ as well instead of what we're doing for those at the moment. Right now, on arm32, the type you get from the expression (NULL - NULL) isn't actually the same thing that we defined as ptrdiff_t... it ends up being the same length so it doesn't really matter, but it's still technically incorrect.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a8fa97c6961991dd8e291d2dc7d8762f83cad6d
Gerrit-Change-Number: 55075
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Sat, 05 Jun 2021 00:44:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment