Vijay P Hiremath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37870 )
Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................
Patch Set 25:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37870/25/src/soc/intel/tigerlake/ea...
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/37870/25/src/soc/intel/tigerlake/ea...
PS25, Line 49: printk(BIOS_DEBUG, "tcss_req[0]-> 0x%x\n"
: "tcss_req[1]-> 0x%x\n\t", tcss_req[0], tcss_req[1]);
:
: /* Copy the request into the buffer */
: memcpy(wbuf, tcss_req, req_size);
:
: return pmc_send_ipc_cmd(cmd.cmd, wbuf, rbuf);
make a common function for all requests
Note: return value is in specific format, pls take a look at Kernel implementation
https://review.coreboot.org/c/coreboot/+/37870/25/src/soc/intel/tigerlake/ea...
PS25, Line 151: int mux_flags, dp_mode;
move to line 161, make uint8_t to keep consistent
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45c3fe9d4a2ec2f2f51b78cca2bd7e623540c00e
Gerrit-Change-Number: 37870
Gerrit-PatchSet: 25
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Comment-Date: Fri, 07 Feb 2020 22:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment