Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Paul Menzel, Fred Reitberger, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67137 )
Change subject: Add support for PSP NVRAM base addr and size
......................................................................
Patch Set 4:
(1 comment)
File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/67137/comment/53097c35_b48af364
PS4, Line 279: uint64_t dest;
: size_t size;
Are these 2 fields needed here?
yes, as when filename does not exist then dest addr and size will be updated in psp dir for PSP_NVRAM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1664893db6f6dcdc588aeaf9448c2d81390af5fa
Gerrit-Change-Number: 67137
Gerrit-PatchSet: 4
Gerrit-Owner: ritul guru
ritul.bits@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Sep 2022 06:36:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Gerrit-MessageType: comment