Attention is currently required from: Shelley Chen, Philip Chen. Hello Shelley Chen, Philip Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/57004
to review the following change.
Change subject: google/trogdor: Read SKU ID as binary-first base3 strapping ......................................................................
google/trogdor: Read SKU ID as binary-first base3 strapping
We're running out of SKU IDs in the base2 system, so convert it to binary-first base3.
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: Ia7f749fa042d3eac76bfe1e74531905c6e279ad2 --- M src/mainboard/google/trogdor/boardid.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/57004/1
diff --git a/src/mainboard/google/trogdor/boardid.c b/src/mainboard/google/trogdor/boardid.c index ddb240a..c972160 100644 --- a/src/mainboard/google/trogdor/boardid.c +++ b/src/mainboard/google/trogdor/boardid.c @@ -51,9 +51,9 @@
if (id == UNDEFINED_STRAPPING_ID) { if (use_old_pins()) - id = gpio_base2_value(old_pins, ARRAY_SIZE(old_pins)); + id = gpio_binary_first_base3_value(old_pins, ARRAY_SIZE(old_pins)); else - id = gpio_base2_value(pins, ARRAY_SIZE(pins)); + id = gpio_binary_first_base3_value(pins, ARRAY_SIZE(pins)); }
return id;