Attention is currently required from: Rob Barnes. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59839 )
Change subject: mb/google/guybrush/dewatt: initial dewatt device config ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/59839/comment/daf54c1d_39cdfb38 PS1, Line 18: /* EN_SPKR */
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/59839/comment/48706554_01d2084b PS1, Line 19: PAD_GPO(GPIO_70, HIGH),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/59839/comment/cdfcc479_9aa22284 PS1, Line 19: PAD_GPO(GPIO_70, HIGH),
please, no spaces at the start of a line
Please fix.