Change in coreboot[master]: soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44827 )

Change subject: soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number
......................................................................

soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number

Change-Id: Ie0657123b0eab4bf63f34aea751e632bf091abc5
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/ecam.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44827/1

diff --git a/src/soc/cavium/common/ecam.c b/src/soc/cavium/common/ecam.c
index 88368178..596501a 100644
--- a/src/soc/cavium/common/ecam.c
+++ b/src/soc/cavium/common/ecam.c
@@ -20,7 +20,7 @@
  */
 uint64_t ecam0_get_bar_val(pci_devfn_t dev, u8 bar)
 {
-	size_t cap_offset = pci_s_find_capability(dev, 0x14);
+	size_t cap_offset = pci_s_find_capability(dev, PCI_BASE_ADDRESS_1);
    uint64_t h, l, ret = 0;
    if (cap_offset) {
    	/* Found EA */

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44827 )

Change subject: soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/44827/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44827/1//COMMIT_MSG@7 
PS1, Line 7: soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number
> Use `PCI_BASE_ADDRESS_1` instead of magic number

Change in coreboot[master]: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic n...

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44827

to look at the new patch set (#2).

Change subject: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic number
......................................................................

soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic number

Change-Id: Ie0657123b0eab4bf63f34aea751e632bf091abc5
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/ecam.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44827/2

Change in coreboot[master]: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic n...

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44827 )

Change subject: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic number
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44827/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44827/1//COMMIT_MSG@7 
PS1, Line 7: soc/cavium/common/ecam.c: Use 'PCI_*' macros instead of magic number
> > Use `PCI_BASE_ADDRESS_1` instead of magic number

Done
Thx

Change in coreboot[master]: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic n...

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44827

to look at the new patch set (#4).

Change subject: soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic number
......................................................................

soc/cavium/common/ecam.c: Use 'PCI_BASE_ADDRESS_1' instead of magic number

Change-Id: Ie0657123b0eab4bf63f34aea751e632bf091abc5
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/ecam.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44827/4

Change in coreboot[master]: soc/cavium/common/ecam.c: Use 'PCI_CB_CAPABILITY_LIST' instead of mag...

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44827

to look at the new patch set (#5).

Change subject: soc/cavium/common/ecam.c: Use 'PCI_CB_CAPABILITY_LIST' instead of magic number
......................................................................

soc/cavium/common/ecam.c: Use 'PCI_CB_CAPABILITY_LIST' instead of magic number

Change-Id: Ie0657123b0eab4bf63f34aea751e632bf091abc5
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/ecam.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/44827/5