Attention is currently required from: Subrata Banik.
Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81661?usp=email )
Change subject: drivers/intel/fsp2_0: Make coreboot FSP stack 16-bytes aligned
......................................................................
Patch Set 10:
(1 comment)
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/81661/comment/3c79303f_221aa887 :
PS10, Line 38: sizeof(uint64_t)
can u please check if `__aligned(4)` works here. […]
Yes. Tried x32 with bot 4 and 8 alignment in rex system. Both boots fine and only difference is in the base address.
[SPEW ] Fsp TemporaryRamBase - 0xFEF90E88 << 8 Bytes
[SPEW ] Fsp TemporaryRamBase - 0xFEF90E84 << 4 Bytes
Do you want to change it to 4 for x32 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81661?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I86048c5d3623a29f17a5e492cd67568e4844589c
Gerrit-Change-Number: 81661
Gerrit-PatchSet: 10
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Wed, 24 Apr 2024 16:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment