Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36429 )
Change subject: arch/acpi.h: Use the predefined typedef acpi_addr_t ......................................................................
arch/acpi.h: Use the predefined typedef acpi_addr_t
Use already declared typedef and modify the usage accordingly.
Change-Id: Icc8413050bfae896d78605416aaaaa6a52eb39f1 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M src/arch/x86/include/arch/acpi.h 1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/36429/1
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 20c244c..479067f 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -161,7 +161,7 @@ typedef struct acpi_hpet { acpi_header_t header; u32 id; - struct acpi_gen_regaddr addr; + acpi_addr_t addr; u8 number; u16 min_tick; u8 attributes; @@ -527,7 +527,7 @@ u16 iapc_boot_arch; u8 res2; u32 flags; - struct acpi_gen_regaddr reset_reg; + acpi_addr_t reset_reg; u8 reset_value; u16 ARM_boot_arch; u8 FADT_MinorVersion; @@ -535,14 +535,14 @@ u32 x_firmware_ctl_h; u32 x_dsdt_l; u32 x_dsdt_h; - struct acpi_gen_regaddr x_pm1a_evt_blk; - struct acpi_gen_regaddr x_pm1b_evt_blk; - struct acpi_gen_regaddr x_pm1a_cnt_blk; - struct acpi_gen_regaddr x_pm1b_cnt_blk; - struct acpi_gen_regaddr x_pm2_cnt_blk; - struct acpi_gen_regaddr x_pm_tmr_blk; - struct acpi_gen_regaddr x_gpe0_blk; - struct acpi_gen_regaddr x_gpe1_blk; + acpi_addr_t x_pm1a_evt_blk; + acpi_addr_t x_pm1b_evt_blk; + acpi_addr_t x_pm1a_cnt_blk; + acpi_addr_t x_pm1b_cnt_blk; + acpi_addr_t x_pm2_cnt_blk; + acpi_addr_t x_pm_tmr_blk; + acpi_addr_t x_gpe0_blk; + acpi_addr_t x_gpe1_blk; } __packed acpi_fadt_t;
/* FADT TABLE Revision values */ @@ -634,8 +634,8 @@ /* ECDT (Embedded Controller Boot Resources Table) */ typedef struct acpi_ecdt { acpi_header_t header; - struct acpi_gen_regaddr ec_control; /* EC control register */ - struct acpi_gen_regaddr ec_data; /* EC data register */ + acpi_addr_t ec_control; /* EC control register */ + acpi_addr_t ec_data; /* EC data register */ u32 uid; /* UID */ u8 gpe_bit; /* GPE bit */ u8 ec_id[]; /* EC ID */
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36429 )
Change subject: arch/acpi.h: Use the predefined typedef acpi_addr_t ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36429 )
Change subject: arch/acpi.h: Use the predefined typedef acpi_addr_t ......................................................................
arch/acpi.h: Use the predefined typedef acpi_addr_t
Use already declared typedef and modify the usage accordingly.
Change-Id: Icc8413050bfae896d78605416aaaaa6a52eb39f1 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36429 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/arch/x86/include/arch/acpi.h 1 file changed, 12 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h index 20c244c..479067f 100644 --- a/src/arch/x86/include/arch/acpi.h +++ b/src/arch/x86/include/arch/acpi.h @@ -161,7 +161,7 @@ typedef struct acpi_hpet { acpi_header_t header; u32 id; - struct acpi_gen_regaddr addr; + acpi_addr_t addr; u8 number; u16 min_tick; u8 attributes; @@ -527,7 +527,7 @@ u16 iapc_boot_arch; u8 res2; u32 flags; - struct acpi_gen_regaddr reset_reg; + acpi_addr_t reset_reg; u8 reset_value; u16 ARM_boot_arch; u8 FADT_MinorVersion; @@ -535,14 +535,14 @@ u32 x_firmware_ctl_h; u32 x_dsdt_l; u32 x_dsdt_h; - struct acpi_gen_regaddr x_pm1a_evt_blk; - struct acpi_gen_regaddr x_pm1b_evt_blk; - struct acpi_gen_regaddr x_pm1a_cnt_blk; - struct acpi_gen_regaddr x_pm1b_cnt_blk; - struct acpi_gen_regaddr x_pm2_cnt_blk; - struct acpi_gen_regaddr x_pm_tmr_blk; - struct acpi_gen_regaddr x_gpe0_blk; - struct acpi_gen_regaddr x_gpe1_blk; + acpi_addr_t x_pm1a_evt_blk; + acpi_addr_t x_pm1b_evt_blk; + acpi_addr_t x_pm1a_cnt_blk; + acpi_addr_t x_pm1b_cnt_blk; + acpi_addr_t x_pm2_cnt_blk; + acpi_addr_t x_pm_tmr_blk; + acpi_addr_t x_gpe0_blk; + acpi_addr_t x_gpe1_blk; } __packed acpi_fadt_t;
/* FADT TABLE Revision values */ @@ -634,8 +634,8 @@ /* ECDT (Embedded Controller Boot Resources Table) */ typedef struct acpi_ecdt { acpi_header_t header; - struct acpi_gen_regaddr ec_control; /* EC control register */ - struct acpi_gen_regaddr ec_data; /* EC data register */ + acpi_addr_t ec_control; /* EC control register */ + acpi_addr_t ec_data; /* EC data register */ u32 uid; /* UID */ u8 gpe_bit; /* GPE bit */ u8 ec_id[]; /* EC ID */
-
Name of user not set (Code Review) -
Patrick Georgi (Code Review)