Hello Joel Kitching,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37472
to review the following change.
Change subject: Update vboot submodule to upstream master ......................................................................
Update vboot submodule to upstream master
Updating from commit id 1c4dbaa0: 2019-11-18 Julius Werner Makefile: Fix typo for MOCK_TPM
to commit id 6ef33b99: 2019-11-22 Hung-Te Lin futility: updater: refactor: unify getting temp files for firmware images
This brings in 13 new commits.
Change-Id: Ia3a2724f1f10d205026e62c3653823813b49b460 Signed-off-by: Julius Werner jwerner@chromium.org --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/37472/1
diff --git a/3rdparty/vboot b/3rdparty/vboot index 1c4dbaa..6ef33b9 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 1c4dbaa08419e13366db32ed20244f63c34388a0 +Subproject commit 6ef33b990578a9583a3ac53f2c835d4e16219b25
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37472 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37472 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2: Code-Review+2
i386-elf-ld.bfd: Bootblock exceeded its allotted size! (0x7000)
Are we adding so much code in these 13 new commits?
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37472 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2:
Are we adding so much code in these 13 new commits?
This is due to the loop unrolling. Once my patches to disable it in coreboot land, this should work again. (Will have to do the whole uprev in one CL then since we've kinda crossed dependencies now.)
Julius Werner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37472 )
Change subject: Update vboot submodule to upstream master ......................................................................
Abandoned
Due to cross-dependencies, it has to all be bundled into CB:37315 now.