Attention is currently required from: Riku Viitanen.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74906 )
Change subject: mb/hp: Add new port for compaq_8300_elite_usdt ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/hp/compaq_8300_elite_usdt/board_info.txt:
https://review.coreboot.org/c/coreboot/+/74906/comment/e16206fb_e68170ba PS1, Line 5: Flashrom support: n Why not ?
File src/mainboard/hp/compaq_8300_elite_usdt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74906/comment/bb891224_65fc2bb9 PS1, Line 9: register "gen2_dec" = "0x00fc0801" The latter seems like reasonable I/O decode for 0x800. But is 0xa00 wrong and 0x600 missing?
https://review.coreboot.org/c/coreboot/+/74906/comment/da497359_e30cc10b PS1, Line 80: io 0x60 = 0x600 LPC decode required from 0x600
https://review.coreboot.org/c/coreboot/+/74906/comment/e8aa970a_5b05a62f PS1, Line 128: io 0x62 = 0x0690 IO decode would probably end at 0x700, and 256 bytes maybe the only choice for the range.
File src/mainboard/hp/compaq_8300_elite_usdt/gpio.c:
https://review.coreboot.org/c/coreboot/+/74906/comment/635e3fae_d4e27439 PS1, Line 5: static const struct pch_gpio_set1 pch_gpio_set1_mode = { Did you capture these tables with inteltool booting with OEM?