Attention is currently required from: Felix Singer, Lance Zhao, Michał Żygowski, Michał Kopeć, Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68787 )
Change subject: acpigen: export acpigen_write_field_name
......................................................................
Patch Set 4:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/68787/comment/a89c75bb_482b6502
PS2, Line 523: void acpigen_write_field_name(const char *name, uint32_t size);
I wrote a suggestion on the patch using this to avoid duplicating most of acpigen_write_field. […]
see https://review.coreboot.org/c/coreboot/+/68791/4..8/src/ec/clevo/it5570e/ssd...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68787
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89f9569c33949995d3b45a5f871ff2cb84a6610
Gerrit-Change-Number: 68787
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 02 Nov 2022 17:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment