Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )

Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
......................................................................

Patch Set 14: -Code-Review

(4 comments)

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/em... 
File src/soc/mediatek/mt8183/emi.c:

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/em... 
PS11, Line 51: enum {
> Rather than this and a raw uint array, please define a struct with three members.

(or delete this enum since only VCORE is needed?

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/em... 
PS11, Line 59: 1125000, 600000
> If the latter two values are always constant, do they really need to be in here?

Agree with Julius - can we delete them?

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/em... 
PS11, Line 400: #if DUAL_FREQ_K
> This seems to be like a very complicated way to write […]

Ack

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/in... 
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:

https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/in... 
PS11, Line 41: #define DUAL_FREQ_K   0
> What is this? If you want configurable code paths, use Kconfig.

Ack