Attention is currently required from: Martin Roth, Tim Wawrzynczak, Meera Ravindranath, Aamir Bohra, Andrey Petrov, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49474 )
Change subject: drivers/intel/fsp2_0: Add support for MP services2 PPI ......................................................................
Patch Set 9: Code-Review+1
(5 comments)
File src/drivers/intel/fsp2_0/include/fsp/ppi/mp_service_ppi.h:
https://review.coreboot.org/c/coreboot/+/49474/comment/04fa2d33_411e243e PS6, Line 49: /* : * switches the requested AP to be the BSP : */ : efi_return_status_t mp_switch_bsp(void); : : /* : * enable or disable an AP. This service may only be called from the BSP. : */ : efi_return_status_t mp_enable_disable_ap(void); :
wanted to match to : […]
I think Tim meant:
``` static efi_return_status_t mps2_enable_disable_ap( efi_pei_mp_services_ppi *ignored1, efi_uintn_t ignored2, efi_boolean_t ignored3, efi_uint32_t *ignored4) { return fsp_ppi_unsupported(); } ```
and so on.
File src/drivers/intel/fsp2_0/ppi/mp_service1.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/f9d1dee7_6470838e PS9, Line 13: nit: space instead of tab.
https://review.coreboot.org/c/coreboot/+/49474/comment/b056f8bb_d8246f05 PS9, Line 58: nit: blank line not required -- to keep it consistent with above functions.
File src/drivers/intel/fsp2_0/ppi/mp_service2.c:
https://review.coreboot.org/c/coreboot/+/49474/comment/4bff9787_2adff9e3 PS9, Line 14: nit: space instead of tab.
https://review.coreboot.org/c/coreboot/+/49474/comment/ea6408d5_9ca42bbb PS9, Line 67: nit: blank line not required -- to keep it consistent with above functions.