Change in coreboot[master]: [Try] mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [Try] mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
[Try] mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Untested.
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 3 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/1
diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig index 95d3b7e..d2dda67 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig +++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig @@ -18,7 +18,6 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select ROMCC_BOOTBLOCK select CPU_AMD_AGESA_FAMILY14 select NORTHBRIDGE_AMD_AGESA_FAMILY14 select SOUTHBRIDGE_AMD_CIMX_SB800 diff --git a/src/mainboard/jetway/nf81-t56n-lf/Makefile.inc b/src/mainboard/jetway/nf81-t56n-lf/Makefile.inc index ba56286..bf86007 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Makefile.inc +++ b/src/mainboard/jetway/nf81-t56n-lf/Makefile.inc @@ -20,6 +20,8 @@ pci$(stripped_ahcibios_id).rom-type := optionrom endif
+bootblock-y += bootblock.c + romstage-y += buildOpts.c romstage-y += BiosCallOuts.c romstage-y += OemCustomize.c diff --git a/src/mainboard/jetway/nf81-t56n-lf/romstage.c b/src/mainboard/jetway/nf81-t56n-lf/bootblock.c similarity index 87% rename from src/mainboard/jetway/nf81-t56n-lf/romstage.c rename to src/mainboard/jetway/nf81-t56n-lf/bootblock.c index 5e61bdd..5ecfaf7 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/romstage.c +++ b/src/mainboard/jetway/nf81-t56n-lf/bootblock.c @@ -14,16 +14,14 @@ * GNU General Public License for more details. */
-#include <northbridge/amd/agesa/state_machine.h> +#include <bootblock_common.h> #include <superio/fintek/common/fintek.h> #include <superio/fintek/f71869ad/f71869ad.h> -#include <sb_cimx.h>
/* Ensure Super I/O config address (i.e., 0x2e or 0x4e) matches that of devicetree.cb */ #define SERIAL_DEV PNP_DEV(0x2e, F71869AD_SP1)
-void board_BeforeAgesa(struct sysinfo *cb) +void bootblock_mainboard_early_init(void) { - sb_Poweron_Init(); fintek_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); }
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37750
to look at the new patch set (#2).
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig.name M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37750
to look at the new patch set (#3).
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/3
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 3: Code-Review+1
Maybe it's better to include the fixes of Kconfig and Kconfig.name to this change, in case this board's owner doesn't come in time before Dec 31 and we need it to be merged urgently. I've done it this way in CB:37869 with Gizmo2.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 3:
Edward, do you still have this device?
Hello Mike Banon, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37750
to look at the new patch set (#4).
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware. To test, please fix the mainbord's Kconfig and Kconfig.name
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig.name M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/4
Hello Mike Banon, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37750
to look at the new patch set (#5).
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig.name M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 5:
Patch Set 3: Code-Review+1
Maybe it's better to include the fixes of Kconfig and Kconfig.name to this change, in case this board's owner doesn't come in time before Dec 31 and we need it to be merged urgently. I've done it this way in CB:37869 with Gizmo2.
Done. for the other boards, Please feel free to edit my changes here: https://review.coreboot.org/q/owner:ehaouas%2540noos.fr+status:open+Switch+a...
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 3: Code-Review+1
Maybe it's better to include the fixes of Kconfig and Kconfig.name to this change, in case this board's owner doesn't come in time before Dec 31 and we need it to be merged urgently. I've done it this way in CB:37869 with Gizmo2.
Done. for the other boards, Please feel free to edit my changes here: https://review.coreboot.org/q/owner:ehaouas%2540noos.fr+status:open+Switch+a...
All done! Searching by "#select ROMCC_BOOTBLOCK", it seems the remaining boards are
./src/mainboard/bap/ode_e21XX ./src/mainboard/bap/ode_e20XX ./src/mainboard/hp/abm ./src/mainboard/amd/olivehillplus ./src/mainboard/amd/olivehill ./src/mainboard/amd/lamar ./src/mainboard/amd/db-ft3b-lc ./src/mainboard/amd/bettong
and maybe ./src/mainboard/elmex/pcm205401 although it doesn't contain this for some reason, unlike pcm205400 already done by you (also need to check, some Kconfig have a stuff like config ELMEX_BOARDS_DISABLED - bool "Boards from vendor are disabled").
I plan to do all this before the Dec 31 - since we've started saving these rare boards, it's better to save them all
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 7:
Patch Set 5:
Patch Set 5:
Patch Set 3: Code-Review+1
Maybe it's better to include the fixes of Kconfig and Kconfig.name to this change, in case this board's owner doesn't come in time before Dec 31 and we need it to be merged urgently. I've done it this way in CB:37869 with Gizmo2.
Done. for the other boards, Please feel free to edit my changes here: https://review.coreboot.org/q/owner:ehaouas%2540noos.fr+status:open+Switch+a...
All done! Searching by "#select ROMCC_BOOTBLOCK", it seems the remaining boards are
./src/mainboard/bap/ode_e21XX ./src/mainboard/bap/ode_e20XX ./src/mainboard/hp/abm ./src/mainboard/amd/olivehillplus ./src/mainboard/amd/olivehill ./src/mainboard/amd/lamar ./src/mainboard/amd/db-ft3b-lc ./src/mainboard/amd/bettong
and maybe ./src/mainboard/elmex/pcm205401 although it doesn't contain this for some reason, unlike pcm205400 already done by you (also need to check, some Kconfig have a stuff like config ELMEX_BOARDS_DISABLED - bool "Boards from vendor are disabled").
I plan to do all this before the Dec 31 - since we've started saving these rare boards, it's better to save them all
These remaining-with-ROMCC rare boards seem to be broken: even if switched away from ROMCC_BOOTBLOCK, their builds are failing because of the other reasons (unrelated to new bootblock.c file). I am abandoning their "switch away from ROMCC_BOOTBLOCK" changes (CB:37975 - CB:37982), but if anyone cares about these boards - they can restore these changes and advance.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8:
Three more boards have been saved: CB:37975 (mb/bap/ode_e20XX), CB:37977 (mb/hp/abm) and CB:37978 (mb/amd/olivehill). I'll check if the other boards from CB:37975-CB:37982 range could be saved, the next common error is " CC romstage/mainboard/bap/ode_e21XX/OemCustomize.o src/mainboard/bap/ode_e21XX/OemCustomize.c:100:1: error: no previous prototype for 'OemCustomizeInitEarly' [-Werror=missing-prototypes] OemCustomizeInitEarly ( ^~~~~~~~~~~~~~~~~~~~~ cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors make[1]: *** [Makefile:365: /cb-build/coreboot-gerrit.0/default/ODE_E21XX/romstage/mainboard/bap/ode_e21XX/OemCustomize.o] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit' "
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8:
Patch Set 8:
Three more boards have been saved: CB:37975 (mb/bap/ode_e20XX), CB:37977 (mb/hp/abm) and CB:37978 (mb/amd/olivehill). I'll check if the other boards from CB:37975-CB:37982 range could be saved, the next common error is " CC romstage/mainboard/bap/ode_e21XX/OemCustomize.o src/mainboard/bap/ode_e21XX/OemCustomize.c:100:1: error: no previous prototype for 'OemCustomizeInitEarly' [-Werror=missing-prototypes] OemCustomizeInitEarly ( ^~~~~~~~~~~~~~~~~~~~~ cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror] cc1: all warnings being treated as errors make[1]: *** [Makefile:365: /cb-build/coreboot-gerrit.0/default/ODE_E21XX/romstage/mainboard/bap/ode_e21XX/OemCustomize.o] Error 1 make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit' "
I don't see an obvious solution for this, and can't do it blind without having these boards for a test. So perhaps these boards (with a successful "away from ROMCC_BOOTBLOCK" switch) are all that we could've saved.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8:
Mike, Thx for +2, but we need a test on real hardware.
you probably can give just +1 ;)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8: Code-Review-1
test on hardware is needed
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 8: Code-Review+1
Patch Set 8: Code-Review-1
test on hardware is needed
This board is a bit more rare (although more popular than AMD CRBs), so doubt we would receive a test report for it at the near future - but still it would be nice to save this board, especially considering the time invested by us.
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr
Hello Kyösti Mälkki, Mike Banon, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37750
to look at the new patch set (#9).
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
[TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK
Warning: Not tested on hardware.
Change-Id: Iefecd38d975404b25554ecd232ab40367f35bc3a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig.name M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc R src/mainboard/jetway/nf81-t56n-lf/bootblock.c 4 files changed, 6 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/37750/9
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Edward, please review this very important change for your jetway/nf81-t56n-lf board, the code of which you have contributed a few years ago.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
not tested
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Sad to see this valuable change being abandoned. Please could I take it over?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Patch Set 10:
Sad to see this valuable change being abandoned. Please could I take it over?
this not tested and not maintained board it is time to drop all ROMCC boards.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Sad to see this valuable change being abandoned. Please could I take it over?
this not tested and not maintained board it is time to drop all ROMCC boards.
If I'd have had spare money I'd have bought and tested this jetway/nf81-t56n-lf, gizmosphere/gizmo2 and biostar/a68n_5200 . Unlike the other ROMCC boards, these are significantly more available to ordinary people and shouldn't be dropped. If you really want to drop the ROMCC boards, despite all the hard work and "switch away from ROMCC" easy fixes available (for which there's a 99% chance of working) - drop the other boards, but please don't touch these three.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10:
Sad to see this valuable change being abandoned. Please could I take it over?
this not tested and not maintained board it is time to drop all ROMCC boards.
If I'd have had spare money I'd have bought and tested this jetway/nf81-t56n-lf, gizmosphere/gizmo2 and biostar/a68n_5200 . Unlike the other ROMCC boards, these are significantly more available to ordinary people and shouldn't be dropped. If you really want to drop the ROMCC boards, despite all the hard work and "switch away from ROMCC" easy fixes available (for which there's a 99% chance of working) - drop the other boards, but please don't touch these three.
Mike, feel free to send a patch if you want. But, we can't keep untested and unmaintained ROMCC boards. please send an e-mail to mail list ( https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/ ) to discuss old ROMCC boards.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10:
Patch Set 10:
Sad to see this valuable change being abandoned. Please could I take it over?
this not tested and not maintained board it is time to drop all ROMCC boards.
If I'd have had spare money I'd have bought and tested this jetway/nf81-t56n-lf, gizmosphere/gizmo2 and biostar/a68n_5200 . Unlike the other ROMCC boards, these are significantly more available to ordinary people and shouldn't be dropped. If you really want to drop the ROMCC boards, despite all the hard work and "switch away from ROMCC" easy fixes available (for which there's a 99% chance of working) - drop the other boards, but please don't touch these three.
Mike, feel free to send a patch if you want. But, we can't keep untested and unmaintained ROMCC boards. please send an e-mail to mail list ( https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/ ) to discuss old ROMCC boards.
I still have this board. I can post it to someone if they wish to maintain it?
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Patch Set 10:
Patch Set 10:
I still have this board. I can post it to someone if they wish to maintain it?
Edward, I am quite interested, partially because don't have any fam14 boards yet. However, considering a possibility of customs problems (would be a huge loss if it gets stuck there with no means to retrieve and our customs are a bit random), I could agree only if nobody from US/EU would like to get it. Please post your offer to a coreboot mailing list and lets see if someone wants your board. It seems you're from UK, maybe someone who wants it is close enough to you... Also, it will be really nice of you if meanwhile you could boot test your board with this change - and, if it doesn't work, without it.
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Restored
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37750 )
Change subject: [TESTME]mb/jetway/nf81-t56n-lf: Switch away from ROMCC_BOOTBLOCK ......................................................................
Abandoned
no one will test ... so drop unmaintained board
-
Edward O'Callaghan (Code Review) -
HAOUAS Elyes (Code Review)
-
Mike Banon (Code Review)
-
Paul Menzel (Code Review)