Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
mb/google/volteer/variants/lillipup: add generic SPDs
Add generic LPDDR4x SPD support for the following three memory parts: K4U6E3S4AA-MGCR H9HCNNNBKMMLXR-NEE MT53E512M32D2NP-046 WT:F
BUG=b:170264065 TEST=none
Change-Id: Ie3163763a0ce291f27c43181d35c070c218b461d Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc A src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/46349/1
diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc b/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc new file mode 100644 index 0000000..b7e6944 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:F diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt new file mode 100644 index 0000000..dc87e04 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt @@ -0,0 +1,4 @@ +DRAM Part Name ID to assign +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E512M32D2NP-046 WT:F 0 (0000) diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt new file mode 100644 index 0000000..d0273dc --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt @@ -0,0 +1,3 @@ +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE +MT53E512M32D2NP-046 WT:F
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46349/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46349/1//COMMIT_MSG@11 PS1, Line 11: K4U6E3S4AA-MGCR : H9HCNNNBKMMLXR-NEE : MT53E512M32D2NP-046 WT:F Please add bullet points at the beginning.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Alan Chuang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46349
to look at the new patch set (#2).
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
mb/google/volteer/variants/lillipup: add generic SPDs
Add generic LPDDR4x SPD support for the following three memory parts: • K4U6E3S4AA-MGCR • H9HCNNNBKMMLXR-NEE • MT53E512M32D2NP-046 WT:F
BUG=b:170264065 TEST=none
Change-Id: Ie3163763a0ce291f27c43181d35c070c218b461d Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc A src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/46349/2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46349/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46349/1//COMMIT_MSG@11 PS1, Line 11: K4U6E3S4AA-MGCR : H9HCNNNBKMMLXR-NEE : MT53E512M32D2NP-046 WT:F
Please add bullet points at the beginning.
Done
Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
mb/google/volteer/variants/lillipup: add generic SPDs
Add generic LPDDR4x SPD support for the following three memory parts: • K4U6E3S4AA-MGCR • H9HCNNNBKMMLXR-NEE • MT53E512M32D2NP-046 WT:F
BUG=b:170264065 TEST=none
Change-Id: Ie3163763a0ce291f27c43181d35c070c218b461d Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46349 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- A src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc A src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt 3 files changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc b/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc new file mode 100644 index 0000000..b7e6944 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:F diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt new file mode 100644 index 0000000..dc87e04 --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/dram_id.generated.txt @@ -0,0 +1,4 @@ +DRAM Part Name ID to assign +K4U6E3S4AA-MGCR 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E512M32D2NP-046 WT:F 0 (0000) diff --git a/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt new file mode 100644 index 0000000..d0273dc --- /dev/null +++ b/src/mainboard/google/volteer/variants/lillipup/memory/mem_list_variant.txt @@ -0,0 +1,3 @@ +K4U6E3S4AA-MGCR +H9HCNNNBKMMLXR-NEE +MT53E512M32D2NP-046 WT:F
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46349 )
Change subject: mb/google/volteer/variants/lillipup: add generic SPDs ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: Where's the rest of the mainboard?
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Menzel (Code Review)