Attention is currently required from: Arthur Heymans, Hung-Te Lin, Jeff Daly, Raul Rangel, Philipp Hug, Mariusz Szafrański, Julius Werner, Angel Pons, Andrey Petrov, Patrick Rudolph, Xi Chen, Jason Glenesk, Damien Zammit, Marshall Dawson, Christian Walter, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Fred Reitberger, ron minnich, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55937 )
Change subject: tree-wide: Translate KiB variants of memory allocators
......................................................................
Patch Set 4:
(8 comments)
File src/soc/intel/common/block/systemagent/systemagent.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/f80aa8fa_0bdd492e
PS4, Line 272: CONFIG_EXT_BIOS_WIN_SIZE);
code indent should use tabs where possible
File src/soc/qualcomm/sc7180/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/ef73c37e_a9833652
PS4, Line 17: REGION_SIZE(dram_aop));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/e6687514_b2959f67
PS4, Line 19: REGION_SIZE(dram_soc));
code indent should use tabs where possible
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/c476e20c_ddc48429
PS4, Line 17: REGION_SIZE(dram_soc));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/5b126aa3_8128ba6b
PS4, Line 19: REGION_SIZE(dram_wlan));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/cdf124fe_1c7d98d3
PS4, Line 21: REGION_SIZE(dram_wpss));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/610a4146_c50c7710
PS4, Line 23: REGION_SIZE(dram_aop));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150544):
https://review.coreboot.org/c/coreboot/+/55937/comment/6636229c_9475c46c
PS4, Line 25: REGION_SIZE(dram_cpucp));
code indent should use tabs where possible
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I903c0183e7fc6b14aeb00325cd10cd48682c2e85
Gerrit-Change-Number: 55937
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Jun 2022 12:20:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment