Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes
Clean up the header includes.
Change-Id: I9f61d1a82b37bc0ed803967dc64decf18f44adc9 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/soc/intel/xeon_sp/cpx/cpu.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/47169/1
diff --git a/src/soc/intel/xeon_sp/cpx/cpu.c b/src/soc/intel/xeon_sp/cpx/cpu.c index 5bde819..4e0de87 100644 --- a/src/soc/intel/xeon_sp/cpx/cpu.c +++ b/src/soc/intel/xeon_sp/cpx/cpu.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <console/debug.h> #include <cpu/cpu.h> +#include <cpu/intel/common/common.h> #include <cpu/intel/microcode.h> #include <cpu/intel/turbo.h> #include <cpu/x86/lapic.h> @@ -16,8 +17,9 @@ #include <soc/cpu.h> #include <soc/msr.h> #include <soc/soc_util.h> + #include "chip.h" -#include <cpu/intel/common/common.h> +
static const void *microcode_patch;
Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47169/1/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/47169/1/src/soc/intel/xeon_sp/cpx/c... PS1, Line 22: is having two newlines here intentional?
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47169/1/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/47169/1/src/soc/intel/xeon_sp/cpx/c... PS1, Line 22:
is having two newlines here intentional?
Done
Hello build bot (Jenkins), Jonathan Zhang, Jay Talbott, Stefan Reinauer, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47169
to look at the new patch set (#2).
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes
Clean up the header includes.
Change-Id: I9f61d1a82b37bc0ed803967dc64decf18f44adc9 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/soc/intel/xeon_sp/cpx/cpu.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/47169/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 2: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 2: Code-Review+2
Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
Patch Set 2: Code-Review+1
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47169 )
Change subject: soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes ......................................................................
soc/intel/xeon_sp/cpx: Reorder cpu.c .h includes
Clean up the header includes.
Change-Id: I9f61d1a82b37bc0ed803967dc64decf18f44adc9 Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47169 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Jay Talbott JayTalbott@sysproconsulting.com --- M src/soc/intel/xeon_sp/cpx/cpu.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Arthur Heymans: Looks good to me, approved Jay Talbott: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/cpx/cpu.c b/src/soc/intel/xeon_sp/cpx/cpu.c index 5bde819..134824a 100644 --- a/src/soc/intel/xeon_sp/cpx/cpu.c +++ b/src/soc/intel/xeon_sp/cpx/cpu.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <console/debug.h> #include <cpu/cpu.h> +#include <cpu/intel/common/common.h> #include <cpu/intel/microcode.h> #include <cpu/intel/turbo.h> #include <cpu/x86/lapic.h> @@ -16,8 +17,8 @@ #include <soc/cpu.h> #include <soc/msr.h> #include <soc/soc_util.h> + #include "chip.h" -#include <cpu/intel/common/common.h>
static const void *microcode_patch;
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Jay Talbott (Code Review)
-
Marc Jones (Code Review)
-
Stefan Reinauer (Code Review)