Attention is currently required from: Julius Werner, Yi Chou, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78407?usp=email )
Change subject: libpayload: Add dma_allocator_range ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78407/comment/9a68b43b_77ec06a7 : PS1, Line 7: dma_allocator_range Please add (), so it’s clear it’s a function.
https://review.coreboot.org/c/coreboot/+/78407/comment/e3fe3f8a_a2e94ce4 : PS1, Line 9: We will need this function to zero out everything allocated by the : dma allocator. Please elaborate. For example, what is the problem?
File payloads/libpayload/libc/malloc.c:
https://review.coreboot.org/c/coreboot/+/78407/comment/6c1fc943_a86da9ee : PS1, Line 126: void dma_allocator_range(void **start_out, size_t *size_out) : { : if (dma_initialized()) { : *start_out = dma->start; : *size_out = dma->end - dma->start; : } else { : *start_out = NULL; : *size_out = 0; : } : } Please add a comment. What is `out` supposed to be?