Attention is currently required from: Vinay Kumar, Maulik V Vaghela, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62630 )
Change subject: mb/google/brya: Disable C state auto demotion for Brya & Brask
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62630/comment/fa357088_a2c3d849
PS5, Line 13: disabling this feature results in 110 mW power savings
Yes, no performance impact was seen with disabling autodemotion.
Isn't that surprising? if I go by the current observation from your side about no perf impact and good power savings by disabling the C-state auto demotion/promotion, then what is the usefulness of this feature. Ideally this feature would provide better energy conservation when enable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62630
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41eea916cdfe4a86e4d263e3191f5cb40fa33a90
Gerrit-Change-Number: 62630
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 08:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinay Kumar
vinay.kumar@intel.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-MessageType: comment