Attention is currently required from: Julius Werner.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67300 )
Change subject: lib/xxhash.c: Add new hash functions ......................................................................
Patch Set 2:
(3 comments)
File src/lib/xxhash.c:
https://review.coreboot.org/c/coreboot/+/67300/comment/428a1b4d_2b879e10 PS1, Line 7: * BSD 2-Clause License (http://www.opensource.org/licenses/bsd-license.php)
Don't need the full text here, that's what the SPDX tag is for.
Wasn't sure of the etiquette here. Trimmed the license text.
https://review.coreboot.org/c/coreboot/+/67300/comment/39f0b83d_c3fa16b6 PS1, Line 57: #endif
unused?
Done
https://review.coreboot.org/c/coreboot/+/67300/comment/2d8e8976_10155192 PS1, Line 90: if (IS_ALIGNED(up, 4)) {
I don't think you want to do this, it's gonna kill your performance. […]
Yeah, the kernel has <asm/unaligned.h> to handle all of these cases. I wasn't sure if there were any coreboot platforms that did not support an efficient unaligned access, so tried to make something work here.
Assuming all platforms support unaligned access simplifies this. If that ever changes in the future, then it would probably be good to abstract that into something similar to <asm/unaligned.h>
-
Fred Reitberger (Code Review)