HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61629 )
Change subject: device/dram/ddr2.c: Fix log messages ......................................................................
device/dram/ddr2.c: Fix log messages
Change 'printk(BIOS_WARNING, "ERROR:' to printk(BIOS_ERR, "'.
Change-Id: Id25bdb1e6b6d7085eff9c2be8263223a91dff061 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/dram/ddr2.c 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/61629/1
diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 0eba0e3..2ade8ef 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -322,13 +322,13 @@ printram("SPD contains 0x%02x bytes\n", spd_size);
if (spd_size < 64 || eeprom_size < 64) { - printk(BIOS_WARNING, "ERROR: SPD to small\n"); + printk(BIOS_ERR, "SPD too small\n"); dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; return SPD_STATUS_INVALID; }
if (spd_ddr2_calc_checksum(spd, spd_size) != spd[63]) { - printk(BIOS_WARNING, "ERROR: SPD checksum error\n"); + printk(BIOS_ERR, "SPD checksum error\n"); dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; return SPD_STATUS_CRC_ERROR; } @@ -336,8 +336,7 @@
reg8 = spd[62]; if ((reg8 & 0xf0) != 0x10) { - printk(BIOS_WARNING, - "ERROR: Unsupported SPD revision %01x.%01x\n", + printk(BIOS_ERR, "Unsupported SPD revision %01x.%01x\n", reg8 >> 4, reg8 & 0xf); dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; return SPD_STATUS_INVALID; @@ -348,7 +347,7 @@ reg8 = spd[2]; printram(" Type : 0x%02x\n", reg8); if (reg8 != 0x08) { - printk(BIOS_WARNING, "ERROR: Unsupported SPD type %x\n", reg8); + printk(BIOS_ERR, "Unsupported SPD type %x\n", reg8); dimm->dram_type = SPD_MEMORY_TYPE_UNDEFINED; return SPD_STATUS_INVALID; }