Change in coreboot[master]: mb/intel/adlrvp: Add 5G WWAN ACPI support for ADL-P RVP - coreboot-gerrit

2 Jun 2022


      Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Selma Bensaid, Paul Menzel.
Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63941 )
Change subject: mb/intel/adlrvp: Add 5G WWAN ACPI support for ADL-P RVP
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/intel/adlrvp/variants/adlrvp_p_ext_ec/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63941/comment/f5164fb9_70d5942a 
PS3, Line 70: 			# register "reset_delay_ms" = "1000"
Why is this comment out ? If unnecessary it should just be removed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10902245e3a5e05cd2af9030394933e936c25396
Gerrit-Change-Number: 63941
Gerrit-PatchSet: 3
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Cliff Huang cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella jeremy.compostella@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid selma.bensaid@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 01 Jun 2022 18:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment