Change in coreboot[master]: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

24 Jul 2019 24 Jul '19

10:26 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34538 )

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This clean my .config from unused ARCH_ARMV8_EXTENSION symbol.

Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm64/armv8/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/1

diff --git a/src/arch/arm64/armv8/Kconfig b/src/arch/arm64/armv8/Kconfig index 2070bea..9d90c4a 100644 --- a/src/arch/arm64/armv8/Kconfig +++ b/src/arch/arm64/armv8/Kconfig @@ -14,6 +14,7 @@ def_bool n select ARCH_RAMSTAGE_ARM64

+if ARCH_ARM64 config ARCH_ARMV8_EXTENSION int default 0 @@ -25,3 +26,4 @@ All ARMv8 implementations are downwards-compatible, so this does not need to be changed unless specific features (e.g. new instructions) are used by the SoC's coreboot code. +endif # ARCH_ARM64

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

24 Jul 24 Jul

12:19 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34538 )

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34538/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/34538/1//COMMIT_MSG@9 PS1, Line 9: clean cleans

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 24 Jul 2019 10:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:02 p.m.

Hello Julius Werner, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#2).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm64/armv8/Kconfig M src/arch/arm64/armv8/Makefile.inc 2 files changed, 5 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1:13 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#3).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1:45 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#4).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1:57 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#5).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:14 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#6).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:24 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#7).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:31 p.m.

Hello Julius Werner, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34538

to look at the new patch set (#8).

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded

This cleans up .config file from unused ARCH_ARMV8_EXTENSION symbol.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/34538/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:40 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34538 )

Change subject: arch/arm64/armv8/Kconfig: Hide ARCH_ARMV8_EXTENSION when unneeded ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/34538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042eb4ab5da53516029e285a0cedb72e7014ffdf Gerrit-Change-Number: 34538 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

2113

days inactive

2113

days old

coreboot-gerrit@coreboot.org

9 comments

2 participants

tags (0)

participants (2)

HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)