Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 )
Change subject: mainboard/google/mistral: Add support for Mistral
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/29949/12/src/mainboard/google/mistral/chrome...
File src/mainboard/google/mistral/chromeos.fmd:
https://review.coreboot.org/#/c/29949/12/src/mainboard/google/mistral/chrome...
PS12, Line 27: RO_PRESERVE {
You should get rid of this now and just directly have RO_DDR_TRAINING(PRESERVE) 8K here (see CB:31707 for details). I'll update Cheza like this as well when I get a chance.
https://review.coreboot.org/#/c/29949/12/src/mainboard/google/mistral/chrome...
PS12, Line 35: RW_ELOG 4K
These four should also have the (PRESERVE) flag now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecfad68bb50f42acf36f51bc3433add56597c3d
Gerrit-Change-Number: 29949
Gerrit-PatchSet: 12
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 06 Mar 2019 19:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment