Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries
In order to add the smbios_slot_desc for the SMBIOS Type9 entries into the devicetree, and not use numbers but strings like "SlotTypePciExpressGen3X4", smbios.h needs to be included in the static.c.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id15fe4101d14479b02e536fdf63748a241c02bd3 --- M src/soc/intel/braswell/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/39351/1
diff --git a/src/soc/intel/braswell/chip.h b/src/soc/intel/braswell/chip.h index 9f790dc..ae9787b 100644 --- a/src/soc/intel/braswell/chip.h +++ b/src/soc/intel/braswell/chip.h @@ -27,6 +27,7 @@ #include <fsp/util.h> #include <intelblocks/lpc_lib.h> #include <soc/pci_devs.h> +#include <smbios.h>
#define SVID_CONFIG1 1 #define SVID_CONFIG3 3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39351/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39351/1//COMMIT_MSG@7 PS1, Line 7: Add Include
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
Patch Set 1:
'smbios.h' is missing here : src/include/device/device.h will "device.h" include 'smbios.h' into 'static.c' ?
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Add smbios.h for Type9 Entries ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Frans Hendriks, Matt DeVillier, Paul Menzel, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39351
to look at the new patch set (#2).
Change subject: soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries ......................................................................
soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries
In order to add the smbios_slot_desc for the SMBIOS Type9 entries into the devicetree, and not use numbers but strings like "SlotTypePciExpressGen3X4", smbios.h needs to be included in the static.c.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id15fe4101d14479b02e536fdf63748a241c02bd3 --- M src/soc/intel/braswell/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/39351/2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39351/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39351/1//COMMIT_MSG@7 PS1, Line 7: Add
Include
Done
Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries ......................................................................
soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries
In order to add the smbios_slot_desc for the SMBIOS Type9 entries into the devicetree, and not use numbers but strings like "SlotTypePciExpressGen3X4", smbios.h needs to be included in the static.c.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Id15fe4101d14479b02e536fdf63748a241c02bd3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39351 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/soc/intel/braswell/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/braswell/chip.h b/src/soc/intel/braswell/chip.h index 9f790dc..ae9787b 100644 --- a/src/soc/intel/braswell/chip.h +++ b/src/soc/intel/braswell/chip.h @@ -27,6 +27,7 @@ #include <fsp/util.h> #include <intelblocks/lpc_lib.h> #include <soc/pci_devs.h> +#include <smbios.h>
#define SVID_CONFIG1 1 #define SVID_CONFIG3 3
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39351 )
Change subject: soc/intel/braswell/chip.h: Include smbios.h for Type9 Entries ......................................................................
Patch Set 3:
The smbios.h is included into chip.h for other SoCs as well. As a following patch I may move the includes to device.h
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Matt DeVillier (Code Review)
-
Michał Żygowski (Code Review)
-
Paul Menzel (Code Review)