Hello Hung-Te Lin, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/36942
to review the following change.
Change subject: mmio: Fix buffer_to_fifo32() order of arguments ......................................................................
mmio: Fix buffer_to_fifo32() order of arguments
buffer_to_fifo32() is a simple wrapper to buffer_to_fifo32_prefix(), but unfortunately its arguments are swapped. This patch fixes the issue.
Change-Id: I6414bf51dd9de681b3b87bbaf4ea4efc815f7ae1 Signed-off-by: Julius Werner jwerner@chromium.org --- M payloads/libpayload/include/libpayload.h M src/include/device/mmio.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/36942/1
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 80bfaae..4f6fcbc 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -457,7 +457,7 @@ static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo, int fifo_stride, int fifo_width) { - buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo, + buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo, fifo_stride, fifo_width); } #endif diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h index df36eb6..6596cf8 100644 --- a/src/include/device/mmio.h +++ b/src/include/device/mmio.h @@ -48,7 +48,7 @@ static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo, int fifo_stride, int fifo_width) { - buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo, + buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo, fifo_stride, fifo_width); }
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36942 )
Change subject: mmio: Fix buffer_to_fifo32() order of arguments ......................................................................
Patch Set 1:
There are no any existing users, right?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36942 )
Change subject: mmio: Fix buffer_to_fifo32() order of arguments ......................................................................
Patch Set 1: Code-Review+2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36942 )
Change subject: mmio: Fix buffer_to_fifo32() order of arguments ......................................................................
Patch Set 1:
There are no any existing users, right?
Yeah (only of buffer_to_fifo32_prefix() directly). I asked Qualcomm to try this and they found the bug.
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36942 )
Change subject: mmio: Fix buffer_to_fifo32() order of arguments ......................................................................
mmio: Fix buffer_to_fifo32() order of arguments
buffer_to_fifo32() is a simple wrapper to buffer_to_fifo32_prefix(), but unfortunately its arguments are swapped. This patch fixes the issue.
Change-Id: I6414bf51dd9de681b3b87bbaf4ea4efc815f7ae1 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36942 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/libpayload/include/libpayload.h M src/include/device/mmio.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index bfe9da5..0bd5db8 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -458,7 +458,7 @@ static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo, int fifo_stride, int fifo_width) { - buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo, + buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo, fifo_stride, fifo_width); } #endif diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h index df36eb6..6596cf8 100644 --- a/src/include/device/mmio.h +++ b/src/include/device/mmio.h @@ -48,7 +48,7 @@ static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo, int fifo_stride, int fifo_width) { - buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo, + buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo, fifo_stride, fifo_width); }
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)