Attention is currently required from: Martin L Roth, Paul Menzel, Maximilian Brune.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74220 )
Change subject: util/lint/stable-017: Update full config pattern matching
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74220/comment/b6ef0a20_7162003c
PS2, Line 9: CONFIG_ARCH gives false positives for CONFIG_USE_EXP_X86_64_SUPPORT so
: use a different string: 'CONFIG_MAINBOARD_DIR'.
I don't understand. How does CONFIG_USE_EXP_X86_64_SUPPORT influence the grep for CONFIG_ARCH_? I only see that CONFIG_USE_EXP_X86_64_SUPPORT selects ARCH_ALL_STAGES_X86_64.
ARCH_ALL_STAGES_X86_64 is not a configurable option, so that is apparently also not the issue.
I tried it out and there also seems to be no problem with the current configs directory.
Sorry wrong config option. Fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5d4fc4693bc303afb16884c53c9ca4d1778a5cb
Gerrit-Change-Number: 74220
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 11:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment