Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32216
Change subject: hatch: Add ACPI support for BT reset functionality ......................................................................
hatch: Add ACPI support for BT reset functionality
Expose the BT_DISABLE_L signal in Hatch's devicetree, on both USB2 port 5 and 10.
BUG=b:123293169 BRANCH=none TEST=compiles, verified kernel is able to find the reset-gpio
Change-Id: I6e4d9786e44f12da71533b6740fdd390f3a57e40 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32216/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 2f1120a..7dd41a2 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -131,6 +131,7 @@ chip drivers/usb/acpi register "desc" = ""Discrete bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" device usb 2.4 on end end chip drivers/usb/acpi @@ -146,6 +147,7 @@ chip drivers/usb/acpi register "desc" = ""Integrated CnVi bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" device usb 2.9 on end end chip drivers/usb/acpi
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32216 )
Change subject: hatch: Add ACPI support for BT reset functionality ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32216/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32216/1//COMMIT_MSG@11 PS1, Line 11: Mention *Bluetooth* once in the commit message for `git log --grep bluetooth -i`?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32216 )
Change subject: hatch: Add ACPI support for BT reset functionality ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32216/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32216/1//COMMIT_MSG@7 PS1, Line 7: hatch: Add ACPI support for BT reset functionality mb/google/hatch
Hello Rajat Jain, Shelley Chen, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32216
to look at the new patch set (#2).
Change subject: mb/google/hatch: Add ACPI support for BT reset functionality ......................................................................
mb/google/hatch: Add ACPI support for BT reset functionality
Expose the Bluetooth BT_DISABLE_L signal in Hatch's devicetree, on both USB2 port 5 and 10.
BUG=b:123293169 BRANCH=none TEST=compiles, verified kernel is able to find the reset-gpio
Change-Id: I6e4d9786e44f12da71533b6740fdd390f3a57e40 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32216/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32216 )
Change subject: mb/google/hatch: Add ACPI support for BT reset functionality ......................................................................
Patch Set 2: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32216 )
Change subject: mb/google/hatch: Add ACPI support for BT reset functionality ......................................................................
mb/google/hatch: Add ACPI support for BT reset functionality
Expose the Bluetooth BT_DISABLE_L signal in Hatch's devicetree, on both USB2 port 5 and 10.
BUG=b:123293169 BRANCH=none TEST=compiles, verified kernel is able to find the reset-gpio
Change-Id: I6e4d9786e44f12da71533b6740fdd390f3a57e40 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32216 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 2f1120a..7dd41a2 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -131,6 +131,7 @@ chip drivers/usb/acpi register "desc" = ""Discrete bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" device usb 2.4 on end end chip drivers/usb/acpi @@ -146,6 +147,7 @@ chip drivers/usb/acpi register "desc" = ""Integrated CnVi bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" device usb 2.9 on end end chip drivers/usb/acpi
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)