Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49963 )
Change subject: device: correct code style
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
i find keeping the else block even though the if blocks before that return much clearer, since it makes the control flow more obvious. i also think that even though the curly brackets aren't required if there's only one statement after an if condition it's not great to remove those. i'll put the curly brackets for single statement if blocks on the agenda for the next coreboot meeting
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49963
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I780251d946d5bea97658476d61d25555ec768dfc
Gerrit-Change-Number: 49963
Gerrit-PatchSet: 4
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 05 Feb 2021 14:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment