HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28648 )
Change subject: nb/intel/i945: Set CxDRT1 tRPALL bit if populated with 8-bank
......................................................................
Patch Set 9:
Also, according to "Intel® 945G/945GZ/945GC/945P/945PL Express
Chipset Family", this bit is reserved on desktop variants. I don't
think it should be set.
regarding that document , Refresh Cycle Time (tRFC), Pre-All to Activate Delay (tRPALL), Activate to Precharge Delay (tRAS), Read to Precharge (tRTP) are also reserved ... ! :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6c7dccd295e187acfe00a08294010af53b4d0ee
Gerrit-Change-Number: 28648
Gerrit-PatchSet: 9
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 13:27:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment