Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63660 )
Change subject: docs/coding_style: Clarify use of GCC extensions
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Is there value in a section on what to do if a developer encounters a GCC extension that their compi […]
I mean, that would only be applicable to HOSTCC code, I think... for coreboot code I think it's well-established that crossgcc is the only compiler we care about and we should keep it that way. (The folks that care about clang should figure out how they want that to work once it is more stable... without integrating anything into Jenkins it's going to be hard to keep any support working long term.)
It would certainly not hurt to have more documentation on crossgcc and general compiler expectations, but I think at that point it's getting pretty far away from "coding style"... maybe that would fit better somewhere under getting_started.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d0eb90d6729fefeb131cdd573ad51f1884afe11
Gerrit-Change-Number: 63660
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 20 Apr 2022 16:41:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment