[S] Change in coreboot[master]: mb/google/myst: Store XHCI PCI resources - coreboot-gerrit

7 Apr 2023


      Attention is currently required from: Jon Murphy.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74281 )
Change subject: mb/google/myst: Store XHCI PCI resources
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/myst/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74281/comment/51f88fb3_df30402c 
PS1, Line 100: 	soc_xhci_store_resources(slots, size);
Just curious, I trace the code a little bit. This is totally can put in SoC common code since the different parameter is defined by Kconfig which is SMM_PCI_RESOURCE_STORE_NUM_SLOTS and no override. Why put in mainboard?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I608d51f438681ac529323c23cc707845a3d609d1
Gerrit-Change-Number: 74281
Gerrit-PatchSet: 1
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Comment-Date: Fri, 07 Apr 2023 01:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment