Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74270 )
Change subject: util/cbfstool: Correct the definition of struct e820entry ......................................................................
util/cbfstool: Correct the definition of struct e820entry
In order to accord with grub (see include/grub/i386/linux.h) and comments for offsets of members of struct linux_params, struct e820entry should be defined as __packed.
Fortunately, the affected area is usually not occupied.
Signed-off-by: Bill XIE persmule@hardenedlinux.org Change-Id: I09955c90e4eec337adca383e628a8821075381d6 --- M util/cbfstool/linux.h 1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/74270/1
diff --git a/util/cbfstool/linux.h b/util/cbfstool/linux.h index dc4575c..2905f35 100644 --- a/util/cbfstool/linux.h +++ b/util/cbfstool/linux.h @@ -27,7 +27,7 @@ #define E820_RESERVED 2 #define E820_ACPI 3 /* usable as RAM once ACPI tables have been read */ #define E820_NVS 4 -}; +} __packed;
/* The header of Linux/i386 kernel */ struct linux_header {