Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39367 )
Change subject: src/soc/tigerlake: add S0ix support fsp_params
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
UPD are availalbe in latest baseline, can you rebaes patch?
PmcLpmS0ixSubStateEnableMask isn't available yet.
is this patch still relevant?
we still have cb:39368 and cb:39369 stacked on top of this,
so if we still want those 2 patches, we need to decide what
we should do here.
I haven't seen an explanation from Intel as to why these params have to be set up this way. At minimum there should be a proper explanation added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf29865e80311d6ef52ea0ff2a722f8d4e845dd7
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 21:29:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment