Attention is currently required from: Naveen M, Paul Menzel, Pranava Y N, Varun Upadhyay.
Karthik Ramasubramanian has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85282?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs ......................................................................
Patch Set 7:
(2 comments)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85282/comment/f0944230_3ae9cdc6?usp... : PS7, Line 110: config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_1; : config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_NONE; : } else { : config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_2; : config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_SDCA; Please set these in the devicetree itself.
File src/drivers/soundwire/alc711/chip.h:
https://review.coreboot.org/c/coreboot/+/85282/comment/775ae108_1417b21d?usp... : PS7, Line 13: [MAX_SNDW_LINKS] In your previous iteration of the change, there was only one instance of the alc711_address. Why do we need 4 instances now based on dev->path.generic.id?