Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74229 )
Change subject: mb/google/rex: Update Rex Flash Layout to fit WP_RO within 4MB
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/74229/comment/262757e3_fd0285bc
PS1, Line 7: 7M
I’d make these non-functional changes a separate commit.
I don't agree with this. This CL attempts to make WP_RO to 4MB hence, all relevant changes are here.
Additionally, i don't know what u mean by non-functional change. if i have to cut 4MB from WP_RO, then i have to give those to some other region to fit within 4MB
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccf83b7bb66d0d5503e0ff9e9a819051296c6724
Gerrit-Change-Number: 74229
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 12:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment