Attention is currently required from: Hung-Te Lin, Ruihai Zhou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78954?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/geralt: Create variant Ciri
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78954/comment/44d1e4d0_a5c734c8 :
PS2, Line 9: and enable MAX98390 AMP for it.
I think it should be enough to say this is a variant of geralt
Variants can differ. This one does not, so please be more specific.
https://review.coreboot.org/c/coreboot/+/78954/comment/6e5d1ad6_43068233 :
PS2, Line 12: TEST=emerge-geralt coreboot
No, not all variants. But I think the build bot will do it.
Then the TEST= line is unrelated and meaningless in my opinion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bbe9ed5e722a70bab1c799a61ce38d2ad58ab25
Gerrit-Change-Number: 78954
Gerrit-PatchSet: 4
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 16:16:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-MessageType: comment